Skip to content

cmd/compile: reduce PGO profile processing overhead #58102

New issue
New issue
Closed
Closed
cmd/compile: reduce PGO profile processing overhead#58102
Assignees
prattmic
Labels
NeedsFixThe path to resolution is known, but the work has not been done.ToolSpeedcompiler/runtimeIssues related to the Go compiler and/or runtime.
Milestone
 
Go1.23
@prattmic

Description

@prattmic
prattmic
opened on Jan 26, 2023
Member

Currently, each cmd/compile invocation parses the full PGO pprof profile, builds a full weight graph, and then determines what is relevant to that package. This is a lot of work that scales poorly with the size of the profile and the size of the build (number of packages). For particularly large profiles, this can lead to extremely long build times.

Follow-up to #55022.

cc @cherrymui @aclements

Activity

prattmic
added
NeedsFixThe path to resolution is known, but the work has not been done.
on Jan 26, 2023
prattmic
added this to the Go1.21 milestone on Jan 26, 2023
prattmic
self-assigned this
on Jan 26, 2023
gopherbot
added
compiler/runtimeIssues related to the Go compiler and/or runtime.
on Jan 26, 2023
bcmills
added
ToolSpeed
on Jan 26, 2023
aclements
mentioned this on Jan 30, 2023
prattmic
added this to Go Compiler / Runtimeon Feb 1, 2023
dr2chase
moved this to Todo in Go Compiler / Runtimeon Feb 1, 2023
gopherbot

gopherbot commented on Feb 1, 2023

@gopherbot
gopherbot
on Feb 1, 2023
Contributor

Change https://go.dev/cl/464575 mentions this issue: WIP: trim profiles to only include transitive deps

prattmic
modified the milestones: Go1.21, Go1.22 on Jun 5, 2023
cespare
mentioned this on Aug 31, 2023
cherrymui

cherrymui commented on Nov 27, 2023

@cherrymui
cherrymui
on Nov 27, 2023
Member

#62400 has a prototype that significantly reduce build time overhead for PGO. It is too late to be integrated in for Go 1.22. Bump to Go 1.23.

cherrymui
modified the milestones: Go1.22, Go1.23 on Nov 27, 2023

32 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

NeedsFixThe path to resolution is known, but the work has not been done.ToolSpeedcompiler/runtimeIssues related to the Go compiler and/or runtime.

Type

No type

Projects

Go Compiler / Runtime

Status

Done

Milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @CAFxX@prattmic@bcmills@gopherbot@cherrymui

      Issue actions
        cmd/compile: reduce PGO profile processing overhead · Issue #58102 · golang/go